-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PurchasesStateProvider
#1502
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
+ Coverage 84.46% 84.50% +0.04%
==========================================
Files 217 218 +1
Lines 7196 7211 +15
Branches 1004 1004
==========================================
+ Hits 6078 6094 +16
+ Misses 730 729 -1
Partials 388 388 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions, lmk what you think!
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesOrchestrator.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesStateProvider.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/common/BillingAbstract.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/google/BillingWrapper.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesStateProvider.kt
Outdated
Show resolved
Hide resolved
54affc5
to
94c1ddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
With #1502 we don't need to pass `appInBackground` as a parameter to the functions in `BillingAbstract`. This PR removes those parameters.
**This is an automatic release.** ### RevenueCatUI * Paywalls: Add `PaywallFooterView` (#1509) via Toni Rico (@tonidero) * Paywalls: Remove `PaywallActivity` theme to pickup application's theme by default (#1511) via Toni Rico (@tonidero) * Paywalls: Auto-close paywall activity if restore grants required entitlement identifier (#1507) via Toni Rico (@tonidero) ### Bugfixes * Improve pricePerYear price calculation precision (#1515) via Toni Rico (@tonidero) * Improve price per month accuracy for weekly subscriptions (#1504) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.0 to 9.4.1 (#1512) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Remove unnecessary appInBackground parameters (#1508) via Cesar de la Vega (@vegaro) * Create `PurchasesStateProvider` (#1502) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This will help removing
appInForeground
as a parameter of many functions, specially in theBillingWrapper
Since this could become a very big refactor I decided to just go with changing the getter of
PurchasesOrchestrator.state
for now to get the state held by aPurchasesStateProvider
.Future PRs will remove the
appInForeground
parameter and access the state directly.